Fix product versions split across pages when using collapsible grouping#480
Closed
utkarshasinha wants to merge 1 commit intoaboutcode-org:mainfrom
Closed
Conversation
Signed-off-by: utkarshasinha <utkarsha20005@gmail.com>
utkarshasinha
force-pushed
the
fix/product-version-pagination-grouping
branch
from
8289f98 to
df49bef
Compare
Contributor
|
@utkarshasinha The issue with this approach is that the entire list of product is selected from the DB to be grouped before being paginated on each request. This is not scalable as the query performances will get worst as the number of product increase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #460
The product list page splits versions of the same product across different pages. For example, a product with 60 versions shows some on page 1 and the rest on page 2 under separate collapsible groups, which is confusing.
This happens because pagination runs before grouping. Fixed by
grouping all versions first, then paginating the groups.